Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for NAP Precompiled Publication #167

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add Support for NAP Precompiled Publication #167

merged 1 commit into from
Jan 16, 2023

Conversation

edarzins
Copy link
Contributor

@edarzins edarzins commented Jan 11, 2023

WIP: Add Agent support for pre-compiled NAP content published via an external source.

Proposed changes

Support the publication of NGINX App Protect (NAP) pre-compiled content (policies and log profiles) from an external source. This is configurable via nginx-agent.conf:

nginx_app_protect: precompiled_publication: true/false

true = Policies and Log Profiles are compiled and published from an external source (tgz files)
false = Policies and Log Profiles are compiled locally (json files)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 75b6643
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63c121c4a1b619000c187800

@inoumbaf5
Copy link
Contributor

@edarzins @oliveromahony @mtbChef please we would like the attribute name to be nms_precompiled_publish or precompiled_nms_publish

@oliveromahony
Copy link
Contributor

Can you run a make deps on your branch?

@edarzins edarzins changed the title Add Support for NAP Optimized Publication Add Support for NAP Precompiled Publication Jan 13, 2023
Add Agent support for pre-compiled NAP content published via
an external source.
@dhurley dhurley added the chore Pull requests for routine tasks label Jan 13, 2023
@dhurley
Copy link
Collaborator

dhurley commented Jan 16, 2023

There is just one extra change that needs to be made for to this PR. The contents of the file src/extensions/nginx-app-protect/nap/nap_content.go should be moved the agent sdk. Seeing as its a holiday in the US today, we will make an exception and merge this PR as it is and I will create a new PR afterwards to move the functionality into the sdk.

@dhurley dhurley merged commit 14196f1 into nginx:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants