Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if app_protect_metadata's nap version is empty first. #144

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

yluf5
Copy link
Contributor

@yluf5 yluf5 commented Dec 9, 2022

There is a case where the DPM sends an empty app_protect_metadata to erase the old meta when the user no longer uses NAP.

Proposed changes

Check if app_protect_metadata's nap version is empty first before we compare the installed NAP version and the metadata NAP version and throw error.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added the bug Something isn't working label Dec 9, 2022
@nickchen
Copy link
Contributor

nickchen commented Dec 9, 2022

LGTM

@yluf5 yluf5 requested a review from nickchen December 9, 2022 17:05
@yluf5 yluf5 merged commit 5384bb8 into release-2.20.0 Dec 9, 2022
@oliveromahony oliveromahony deleted the fix-metadata-nap-version branch February 21, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants