Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arch of apk packages #138

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Dec 8, 2022

Proposed changes

Fix architecture of arm apk packages

Bug

First noticed in pipeline runs:

Before

# Create apk packages
/bin/sh: 3: [: aarch64: unexpected operator
using apk packager...
created package: ./build/packages/apk/v3.13/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.14/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.15/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.16/aarch64/nginx-agent-2.19.0.apk
/bin/sh: 3: [: x86_64: unexpected operator
using apk packager...
created package: ./build/packages/apk/v3.13/x86_64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.14/x86_64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.15/x86_64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.16/x86_64/nginx-agent-2.19.0.apk

After

Ref: https://github.com/nginx/agent/actions/runs/3650619616/jobs/6166828489#step:7:64

# Create apk packages
using apk packager...
created package: ./build/packages/apk/v3.13/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.14/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.15/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.16/aarch64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.13/x86_64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.14/x86_64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.15/x86_64/nginx-agent-2.19.0.apk
using apk packager...
created package: ./build/packages/apk/v3.16/x86_64/nginx-agent-2.19.0.apk

Failing if condition resulted in amd64 binaries placed in arm package

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@Dean-Coakley Dean-Coakley self-assigned this Dec 8, 2022
@github-actions github-actions bot added the bug Something isn't working label Dec 8, 2022
@Dean-Coakley Dean-Coakley merged commit e8567dc into release-2.20.0 Dec 9, 2022
@Dean-Coakley Dean-Coakley deleted the fix-apk-arm-packages branch December 9, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants