Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed metrics #127

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fixed metrics #127

merged 2 commits into from
Dec 5, 2022

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Dec 1, 2022 •
edited
Loading

Proposed changes

Fixed the URL to work the same as the others.
Moved cert scripts to tls folder as they do not generate mTLS scripts.
Updated readme from internal feedback.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added bug Something isn't working dependencies labels Dec 1, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 1, 2022
@oliveromahony oliveromahony merged commit 3c536cb into main Dec 5, 2022
@oliveromahony oliveromahony deleted the metrics_url branch December 5, 2022 11:17
@nickchen nickchen mentioned this pull request Dec 5, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@craigell craigell craigell approved these changes

@aphralG aphralG aphralG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliveromahony @dhurley @Dean-Coakley @craigell @aphralG