Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent api example with prometheus and grafana #118

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Nov 23, 2022

Proposed changes

  • Added an example of how to setup a Grafana dashboard with the NGINX agent.
  • Updated the code to not add the file watcher plugins when no GRPC server is configured in the agent configuration.
  • Updated registration plugin to read the NGINX config when registering an agent so that things like access/error logs are updated on the startup of the agent when no GRPC server is configured.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dhurley dhurley self-assigned this Nov 23, 2022
@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Nov 23, 2022
@dhurley dhurley merged commit 065a5a5 into main Nov 28, 2022
@dhurley dhurley deleted the add-agent-api-example-with-prometheus-and-grafana branch November 28, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants