Skip to content

fix: split subviolations and tc by comma #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

sanathkumarbs
Copy link
Contributor

@sanathkumarbs sanathkumarbs commented Nov 16, 2022

Proposed changes

It was identified that the Threat Campaign and Subviolation values were incorrectly sent as encoded values, whereas it was expected to be comma-delimited.

This PR fixes the Threat Campaign and Subviolation values to be sent as comma-delimited strings.

Testing:

  • Manually tested
  • Updated test cases

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

Copy link

@Laks28 Laks28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes, able to filter by Subviolations.

@sanathkumarbs sanathkumarbs merged commit e8084e2 into main Nov 16, 2022
@sanathkumarbs sanathkumarbs deleted the fix-decoding branch November 16, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants