Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent startup #108

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Agent startup #108

merged 3 commits into from
Nov 16, 2022

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Remove logic that makes the agent connect if grpc Port or server host are not set

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

Dean-Coakley
Dean-Coakley reviewed Nov 11, 2022
View reviewed changes
main.go Show resolved Hide resolved
@oliveromahony oliveromahony merged commit 49e6d10 into main Nov 16, 2022
@oliveromahony oliveromahony deleted the agent_startup branch November 16, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliveromahony @dhurley @Dean-Coakley @aphralG