Skip to content

Conversation

@john-david3
Copy link
Contributor

Proposed changes

  • Added test to make sure config parser is correctly parsing SSL Certs
  • Added tests to check if parser handles multiple certs correctly
  • Created test config files
  • Added new embed in nginx_config.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@john-david3 john-david3 self-assigned this Apr 17, 2025
@john-david3 john-david3 requested a review from a team as a code owner April 17, 2025 13:20
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 17, 2025
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 18, 2025
accessLog.Name(),
certFile,
),
expectedConfigContext: &model.NginxConfigContext{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to create something like modelHelpers.GetConfigContextWithNames maybe modelHelpers.GetConfigContextWithFiles(accessLogName, []mpi.Files, errorlogName) Where we pass in the log names and then the list of expected files. Then it could be reused in Test 3, 4, 5 & 6

@dhurley dhurley merged commit e04179f into v3 Apr 25, 2025
20 checks passed
@dhurley dhurley deleted the check-parsing-ssl-cert branch April 25, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants