Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instance list rest api #101

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Add instance list rest api #101

merged 9 commits into from
Nov 16, 2022

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Nov 9, 2022 •
edited
Loading

Proposed changes

  • Add rest api to list instances

TODO

  • Test coverage
  • Make port configurable

Future Work/Out of Scope

  • TLS support

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@Dean-Coakley Dean-Coakley self-assigned this Nov 9, 2022
dhurley
dhurley reviewed Nov 10, 2022
View reviewed changes
src/plugins/rest_api.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Nov 11, 2022
@Dean-Coakley Dean-Coakley marked this pull request as ready for review November 11, 2022 09:43
dhurley
dhurley reviewed Nov 11, 2022
View reviewed changes
nginx-agent.conf Outdated Show resolved Hide resolved
oliveromahony
oliveromahony reviewed Nov 11, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley merged commit 024594e into main Nov 16, 2022
@Dean-Coakley Dean-Coakley deleted the add-rest-list-instances branch November 16, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony left review comments

@aphralG aphralG aphralG approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees

@Dean-Coakley Dean-Coakley

Labels
dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @oliveromahony @dhurley @aphralG