You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This message is output from src/core/metrics/sources/disk.go:43. What appears to be going on here is that we loop through each mount point and collect disk usage metrics based on each one. However, if the operation fails for a given mount point there we do not output for which mount point an error was encountered.
As such, I'd suggest a change where we replace line 43 with the following:
c.logger.Log(fmt.Sprintf("Failed to get disk metrics for mount point %s, %v", part.Mountpoint, err))
If everyone is amenable, I'll submit a PR for this.
The text was updated successfully, but these errors were encountered:
dekobon
added a commit
to dekobon/agent
that referenced
this issue
Jun 2, 2023
This message is output from
src/core/metrics/sources/disk.go:43
. What appears to be going on here is that we loop through each mount point and collect disk usage metrics based on each one. However, if the operation fails for a given mount point there we do not output for which mount point an error was encountered.As such, I'd suggest a change where we replace line 43 with the following:
If everyone is amenable, I'll submit a PR for this.
The text was updated successfully, but these errors were encountered: