Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't attempt to catch SIGQUIT or SIGKILL #503

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

rhansen
Copy link
Collaborator

@rhansen rhansen commented Mar 3, 2023

SIGKILL can't be caught so there's no point in trying. SIGQUIT is intended as a harsh exit for debugging purposes; it should generate a core dump that accurately depicts the program's state at the time the SIGQUIT was received.

@rhansen rhansen requested a review from buchdag March 3, 2023 00:38
@rhansen
Copy link
Collaborator Author

rhansen commented Mar 3, 2023

Unit tests did not run due to a GitHub outage. I'll re-trigger them some time after the outage is over.

buchdag
buchdag previously approved these changes Mar 14, 2023
SIGKILL can't be caught so there's no point in trying.  SIGQUIT is
intended as a harsh exit for debugging purposes; it should generate a
core dump that accurately depicts the program's state at the time the
SIGQUIT was received.
@buchdag buchdag merged commit a1cd2fa into nginx-proxy:main Mar 14, 2023
@rhansen rhansen deleted the sig branch March 14, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants