Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete "invalid value" debug message accidentally left in #494

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

rhansen
Copy link
Collaborator

@rhansen rhansen commented Feb 12, 2023

Commit e0d71f8 added an "invalid value" debug message that I did not intend to commit. Remove it.

Also refine some tests.

Fixes #497

@rhansen rhansen mentioned this pull request Feb 16, 2023
@rhansen rhansen requested a review from buchdag February 16, 2023 19:07
  * Ensure that `sortObjectsByKeysAsc` and `sortObjectsByKeysDesc` do
    not mutate the input slice.
  * Be more strict when checking the sorted results.
  * Improve readability and reduce duplication by converting to
    idiomatic table-driven tests.
Commit e0d71f8 added an "invalid
value" debug message that I did not intend to commit.  Remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid value spam
2 participants