Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure file generated by docker-gen has the right permission #352

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Jun 15, 2021

#308 by @NicolasDorier, with a minor code formatting correction

If the destination file does not exists, the permissions become 600 because this is the default permission for temp files.

This is problematic, if the container consuming the destination file does not run as root.

Instead, the default permissions should be used (as per umask).
This PR will make permission 644, which is generally what we want. And if the container consuming it is not happy with it, it always can override the permissions.

@NicolasDorier
Copy link
Contributor

Damn 2 years ago. I don't remember I even opened this PR, nor that I did write anything in the previous PR. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants