This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Closed
Conversation
Collaborator
|
Hey, thank you so much for your effort. Unfortunately this repository is going to be archived soon. For once, ngipkgs contains Weblate at 5.6.2 now. But more importantly, the PR to include Weblate 5.6.2 into Nixpkgs is close to being merged and is in a really good state, much better than this flake ever was. I'd really recommend you to deploy from my nixpkgs branch for now and later switch to using the official NixOS module once it's merged. I'd rather not put time into reviewing your update, as it is already outdated compared to the other alternatives, except you have a specific use case for this to be merged. Otherwise I'd archive this start of next week. Let me know what you think. |
Contributor
Author
|
Oh! That's interesting. Wasn't aware of those alternative. For now, I'll continue to point my flake to my fork of this repo until it is merged in NixPkgs. (or maybe sooner if I want to test it, but I have other stuff I prefer to work on for now).
So I'll close this PR whenever I'm back home (or you could. Replying by mail from me phone which don't have the 2FA for GitHub)
11 août 2024 18:10:10 Kerstin ***@***.***>:
…
Hey, thank you so much for your effort. Unfortunately this repository is going to be archived soon. For once, ngipkgs[ngi-nix/ngipkgs#309] contains Weblate at 5.6.2 now. But more importantly, the PR to include Weblate 5.6.2 into Nixpkgs[NixOS/nixpkgs#325541] is close to being merged and is in a really good state, much better than this flake ever was. I'd really recommend you to deploy from my nixpkgs branch[https://github.com/erictapen/nixpkgs/tree/weblate] for now and later switch to using the official NixOS module once it's merged.
I'd rather not put time into reviewing your update, as it is already outdated compared to the other alternatives, except you have a specific use case for this to be merged. Otherwise I'd archive this start of next week. Let me know what you think.
—
Reply to this email directly, view it on GitHub[#5 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AFMKJZERJ4GJJHENCMTZH3LZQ6EDZAVCNFSM6AAAAABMJ3T7ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSHAYDONRXGE].
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test work, it work on my server, so it should be good.
I haven’t ported the celery test, the patch does not apply anymore and I have no problem with the test.
Also it does work with postgresql 15.