Skip to content

Misskey: Projects-old -> Projects#798

Merged
eljamm merged 4 commits into
ngi-nix:mainfrom
OluchiTheAnalyst:misskey-migration
Apr 14, 2025
Merged

Misskey: Projects-old -> Projects#798
eljamm merged 4 commits into
ngi-nix:mainfrom
OluchiTheAnalyst:misskey-migration

Conversation

@OluchiTheAnalyst
Copy link
Copy Markdown
Contributor

@OluchiTheAnalyst OluchiTheAnalyst commented Apr 13, 2025

Copy the template in template/project to the projects directory and rename it as Misskey. Then move the information contained in the projects-old/misskey directory into the projects/misskey directory.

@OluchiTheAnalyst
Copy link
Copy Markdown
Contributor Author

Hey @eljamm here's the error i am getting while trying to run the build command for examples
Screenshot (27)
.
the tests has been built successfully though.

Comment thread projects/Misskey/default.nix Outdated
examples.basic = {
module = ./services/misskey/examples/basic.nix;
description = "";
tests.misskey = import "${sources.inputs.nixpkgs}/nixos/tests/misskey.nix" args;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix the cannot coerce null to a string: null error.

Suggested change
tests.misskey = import "${sources.inputs.nixpkgs}/nixos/tests/misskey.nix" args;
tests.misskey = "${sources.inputs.nixpkgs}/nixos/tests/misskey.nix";

Comment thread projects/Misskey/default.nix Outdated
Comment on lines +14 to +24
nixos.modules.programs = {
Misskey = {
name = "Misskey";
module = ./programs/misskey/module.nix;
examples.basic = {
module = ./programs/misskey/examples/basic.nix;
description = "";
tests.basic = import ./programs/misskey/tests/basic.nix args;
};
};
};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project doesn't have programs. Please remove this and delete the files it references.

Suggested change
nixos.modules.programs = {
Misskey = {
name = "Misskey";
module = ./programs/misskey/module.nix;
examples.basic = {
module = ./programs/misskey/examples/basic.nix;
description = "";
tests.basic = import ./programs/misskey/tests/basic.nix args;
};
};
};

@OluchiTheAnalyst
Copy link
Copy Markdown
Contributor Author

OluchiTheAnalyst commented Apr 14, 2025

Thank you @eljamm . do i have add anything under the settings options?
Screenshot (28)

@eljamm
Copy link
Copy Markdown
Contributor

eljamm commented Apr 14, 2025

Thank you @eljamm . do i have add anything under the settings options? Screenshot (28)

We can re-use some of nixpkgs test's config.

@OluchiTheAnalyst OluchiTheAnalyst marked this pull request as ready for review April 14, 2025 10:31
@OluchiTheAnalyst
Copy link
Copy Markdown
Contributor Author

@eljamm This PR is ready for review

Comment thread projects/Misskey/default.nix Outdated
};

nixos.modules.services = {
Misskey = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Misskey = {
misskey = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already importing the module from nixpkgs:

# default.nix
      module = "${sources.inputs.nixpkgs}/nixos/modules/services/web-apps/misskey.nix";

So we don't need to create another module. Please delete this file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't do anything and we're using the tests from nixpkgs, anways:

#default.nix
tests.misskey = "${sources.inputs.nixpkgs}/nixos/tests/misskey.nix";

Please delete this file.

@OluchiTheAnalyst
Copy link
Copy Markdown
Contributor Author

@eljamm Done!

Copy link
Copy Markdown
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now please delete projects-old/Misskey

@OluchiTheAnalyst
Copy link
Copy Markdown
Contributor Author

Looks good, now please delete projects-old/Misskey

Done! it skipped my mind

Copy link
Copy Markdown
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job.

@eljamm eljamm merged commit 9884bb1 into ngi-nix:main Apr 14, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Nix@NGI Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants