Rosenpass: projects-old -> projects#786
Conversation
There was a problem hiding this comment.
You need to delete projects-old/Rosenpass as well
There was a problem hiding this comment.
I just wanted to be sure I got all the data out of there correctly first.
I will delete the directory now.
Co-authored-by: Fedi Jamoussi <Fedi.Jamoussi@protonmail.ch>
There was a problem hiding this comment.
Since we have a full-fledged tests under projects-old/Rosenpass/tests, we should use them, and not just delete them. Add these to the nixos.modules.services.rosenpass tests.
tests.with-sops = import ./tests args;
tests.without-sops = "${sources.inputs.nixpkgs}/nixos/tests/rosenpass.nix";There was a problem hiding this comment.
What file should I attach for the test?
There was a problem hiding this comment.
What do you mean? You can just set these attributes either in an example or in nixos.tests
There was a problem hiding this comment.
Yeah, I did that but I was getting something about path not existing. I even reverted to use the basic test and I am getting same error
There was a problem hiding this comment.
That's because the path to the tests is wrong. You either move the tests directory to ./tests and set tests.with-sops = import ./tests args; or you set the path to where the directory exists tests.with-sops = import ./<path_where_tests_directory_is> args;
…into migrate-rosenpass
There was a problem hiding this comment.
Let's delete this since it's not testing anything
There was a problem hiding this comment.
That's because the path to the tests is wrong. You either move the tests directory to ./tests and set tests.with-sops = import ./tests args; or you set the path to where the directory exists tests.with-sops = import ./<path_where_tests_directory_is> args;
| sources.modules.programs._serviceName_ | ||
| sources.examples._ProjectName_._exampleName_ # i.e _ProjectName_.basic |
There was a problem hiding this comment.
- You need to replace
_serviceName_with the actual service name... - But let's just delete this file since it doesn't test anything
| sources.modules.programs._serviceName_ | |
| sources.examples._ProjectName_._exampleName_ # i.e _ProjectName_.basic | |
| sources.modules.programs._serviceName_ | |
| sources.examples._ProjectName_._exampleName_ # i.e _ProjectName_.basic |
| { ... }: | ||
|
|
||
| { | ||
| services._serviceName_.enable = true; |
There was a problem hiding this comment.
It's not enough to copy the template, you need to modify it as well... _serviceName_ should be replace with the actual service name
Co-authored-by: Fedi Jamoussi <Fedi.Jamoussi@protonmail.ch>
Co-authored-by: Fedi Jamoussi <Fedi.Jamoussi@protonmail.ch>
|
I just moved the tests to ./tests and we still have the same error.
I really thought this would be a walk in the park. |
|
The command should be: Where |
There was a problem hiding this comment.
Please remove this file. It's not testing anything.
There was a problem hiding this comment.
Please remove this file. It's not testing anything.
There was a problem hiding this comment.
Either modify the template names or just remove this file.
|
How does it look now? |
eljamm
changed the title
2 participants
fixes #742