Flarum: Projects-old -> Projects#779
Merged
Merged
Conversation
Contributor
Author
|
@eljamm Please could you review this? |
eljamm
reviewed
Apr 10, 2025
| module = "${sources.inputs.nixpkgs}/nixos/modules/services/web-apps/flarum.nix"; | ||
| examples.basic = { | ||
| module = ./services/Flarum/examples/basic.nix; | ||
| description = "Flarum is a delightfully simple discussion platform for your website"; |
Contributor
There was a problem hiding this comment.
This is a description for the example, not the project
Suggested change
| description = "Flarum is a delightfully simple discussion platform for your website"; | |
| description = ""; |
| module = ./programs/Flarum/module.nix; | ||
| examples.basic = { | ||
| module = ./programs/Flarum/examples/basic.nix; | ||
| description = "Discussion community"; |
Contributor
There was a problem hiding this comment.
This is a description for the example, not the project
| { ... }: | ||
|
|
||
| { | ||
| programs.Flarum.enable = true; |
Contributor
There was a problem hiding this comment.
Should be lower case
Suggested change
| programs.Flarum.enable = true; | |
| programs.flarum.enable = true; |
Comment on lines
+8
to
+11
| cfg = config.programs.Flarum; | ||
| in | ||
| { | ||
| options.programs.Flarum = { |
Contributor
There was a problem hiding this comment.
Suggested change
| cfg = config.programs.Flarum; | |
| in | |
| { | |
| options.programs.Flarum = { | |
| cfg = config.programs.flarum; | |
| in | |
| { | |
| options.programs.flarum = { |
| { ... }: | ||
|
|
||
| { | ||
| programs.Flarum.enable = true; |
Contributor
There was a problem hiding this comment.
Suggested change
| programs.Flarum.enable = true; | |
| programs.flarum.enable = true; |
OluchiTheAnalyst
force-pushed
the
flarum-migration
branch
2 times, most recently
from
5f481cc to
51cc193
Compare
OluchiTheAnalyst
force-pushed
the
flarum-migration
branch
from
51cc193 to
2ccccbe
Compare
eljamm
reviewed
Apr 10, 2025
Comment on lines
+18
to
+23
| module = ./programs/Flarum/module.nix; | ||
| examples.basic = { | ||
| module = ./programs/Flarum/examples/basic.nix; | ||
| description = ""; | ||
| tests.basic = null; | ||
| }; |
Contributor
There was a problem hiding this comment.
How about we just do this? Just don't forget to create the files
Suggested change
| module = ./programs/Flarum/module.nix; | |
| examples.basic = { | |
| module = ./programs/Flarum/examples/basic.nix; | |
| description = ""; | |
| tests.basic = null; | |
| }; | |
| module = ./module.nix; | |
| examples.basic = { | |
| module = ./programs-example.nix; | |
| description = ""; | |
| tests.basic = null; | |
| }; |
| name = "flarum"; | ||
| module = "${sources.inputs.nixpkgs}/nixos/modules/services/web-apps/flarum.nix"; | ||
| examples.basic = { | ||
| module = ./services/Flarum/examples/basic.nix; |
Contributor
There was a problem hiding this comment.
Suggested change
| module = ./services/Flarum/examples/basic.nix; | |
| module = ./service-example.nix; |
Contributor
Author
|
@eljamm Done! |
eljamm
reviewed
Apr 11, 2025
| @@ -0,0 +1,4 @@ | |||
| { ... }: | |||
| { | |||
| programs.flarum.enable = true; | |||
Contributor
There was a problem hiding this comment.
Since this is an example for the service
Suggested change
| programs.flarum.enable = true; | |
| services.flarum.enable = true; |
OluchiTheAnalyst
force-pushed
the
flarum-migration
branch
from
bfd9fb2 to
1759176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the template in template/project to the projects directory and rename it as
Flarum. Then move the information contained in theprojects-old/flarumdirectory into theprojects/flarumdirectory.