Skip to content

ci: add VM test-demo workflow#719

Merged
fricklerhandwerk merged 2 commits into
ngi-nix:mainfrom
imincik:ci-test-demo
May 12, 2025
Merged

ci: add VM test-demo workflow#719
fricklerhandwerk merged 2 commits into
ngi-nix:mainfrom
imincik:ci-test-demo

Conversation

@imincik
Copy link
Copy Markdown
Contributor

@imincik imincik commented Apr 7, 2025

No description provided.

@imincik imincik moved this to In progress in Nix@NGI Apr 7, 2025
@imincik imincik linked an issue Apr 7, 2025 that may be closed by this pull request
CI test for the service demo workflow #698
Closed
@imincik imincik force-pushed the ci-test-demo branch 3 times, most recently from a904153 to 2ff99a5 Compare April 7, 2025 07:32
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Apr 7, 2025

Unrelated error messages

 fatal: cannot change to '/home/runner/.cache/nix/gitv3/0glrjg6yk3b68jqm6lz05qsv63iapg08p0aa3qx725qw1ygh94va': No such file or directory
warning: could not update cached head 'refs/heads/canon' for 'https://code.tvl.fyi/depot.git:/nix/yants.git'

eljamm
eljamm reviewed Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static analysis for the workflow using zizmor:

$ zizmor .github/workflows/test-demo.yaml
6 findings (4 suppressed): 0 unknown, 0 informational, 0 low, 2 medium, 0 high

Comment thread .github/workflows/test-demo.yaml
Comment thread .github/workflows/test-demo.yaml
@imincik imincik force-pushed the ci-test-demo branch 4 times, most recently from 78af612 to b0042a2 Compare April 7, 2025 07:43
@imincik imincik closed this Apr 7, 2025
@github-project-automation github-project-automation Bot moved this from In progress to Done in Nix@NGI Apr 7, 2025
@imincik imincik reopened this Apr 7, 2025
@github-project-automation github-project-automation Bot moved this from Done to Blocked in Nix@NGI Apr 7, 2025
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Apr 7, 2025

Just found

root@debian-sid:~# cat /etc/nix/nix.conf
# see https://nixos.org/manual/nix/stable/command-ref/conf-file

sandbox = true

@imincik imincik force-pushed the ci-test-demo branch 12 times, most recently from 5ba8f17 to 31d4a0f Compare April 7, 2025 12:38
@imincik imincik force-pushed the ci-test-demo branch 8 times, most recently from da1061b to 2a0b92c Compare April 9, 2025 17:47
fricklerhandwerk
fricklerhandwerk reviewed Apr 9, 2025
View reviewed changes
Comment thread .github/workflows/test-demo.yaml Outdated
@imincik imincik force-pushed the ci-test-demo branch 2 times, most recently from 57c46d1 to 449a6a5 Compare April 11, 2025 10:54
@imincik imincik changed the title ci: add test-demo workflow ci: add VM test-demo workflow Apr 11, 2025
@imincik imincik force-pushed the ci-test-demo branch 3 times, most recently from b761cef to d604ad1 Compare April 28, 2025 08:08
@imincik imincik marked this pull request as ready for review April 28, 2025 08:08
@imincik imincik moved this from In progress to In review in Nix@NGI Apr 28, 2025
eljamm
eljamm reviewed Apr 28, 2025
View reviewed changes
Comment thread .github/workflows/test-demo.sh Outdated
Comment thread .github/workflows/test-demo.sh
Comment thread .github/workflows/test-demo.sh
eljamm
eljamm reviewed Apr 28, 2025
View reviewed changes
Comment thread .github/workflows/test-demo.yaml
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented May 12, 2025

zizmor report:

zizmor .github/workflows/test-demo.yaml
INFO zizmor: skipping impostor-commit: can't run without a GitHub API token
INFO zizmor: skipping ref-confusion: can't run without a GitHub API token
INFO zizmor: skipping known-vulnerable-actions: can't run without a GitHub API token
INFO zizmor: skipping forbidden-uses: audit not configured
INFO audit: zizmor: 🌈 completed .github/workflows/test-demo.yaml
No findings to report. Good job!

eljamm
eljamm approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildbot failures are unrelated to this. LGTM

@eljamm eljamm mentioned this pull request Nov 10, 2025
Closed
@ngi-nix-bot ngi-nix-bot mentioned this pull request Nov 11, 2025
Merged
@ngi-nix-bot ngi-nix-bot mentioned this pull request Dec 1, 2025
Merged
@ngi-nix-bot ngi-nix-bot mentioned this pull request Mar 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eljamm eljamm eljamm approved these changes

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

Assignees

No one assigned

Labels

None yet

Projects

Nix@NGI
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI test for the service demo workflow

3 participants

@imincik @fricklerhandwerk @eljamm