overview: render project snippets with deliverable type and summary text#685
Conversation
eljamm
left a comment
There was a problem hiding this comment.
This looks very cool. Thanks!
44cf769 to
25a2d4b
Compare
| '') projects | ||
| ); | ||
| project: | ||
| optionalString (project.packages != { }) (one "Executable") |
There was a problem hiding this comment.
| optionalString (project.packages != { }) (one "Executable") | |
| optionalString (project.packages != { }) (one "program") |
That corresponds to the module subtree, we may or may not want to keep around that terminology.
Later we can even reasonably leave that in plural, and then display a number to indicate how many there are -- it may be multiple, but AFAIK we don't have that case yet.
This may be an arbitrary nit, but I prefer to leave it not capitalised since there's no reason to (it's not the start of a sentence or anything of that kind), and if you really care I think this can be fixed in CSS.
But this is surely worth a good debate on naming, because both "program" and "executable" don't say much about the difference to "service". Maybe "command" would be more suitable, since you issue that deliberately to run an executable as opposed to a an executable being started automatically to run as a service.
There was a problem hiding this comment.
I'm not even sure where I got these four categories from, but I also used these in #575.
I don't care much about how we call them currently, as we get the data right from the model and changing the implementation is still easy. So let's go with program for now. We might stumble over better terms through talking with users/explaining NGIpkgs to them.
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Nice, except for the bikeshed.
a003796 to
9fc4564
Compare
For now I'd only show the type of existing deliverables and the summary text if existent.