Re-Isearch: Add a VM test#586
Merged
Merged
Conversation
Contributor
|
Having that note in the code would be great so we don't lose track of that information. |
fricklerhandwerk
previously approved these changes
Mar 13, 2025
OPNA2608
commented
Mar 13, 2025
OPNA2608
force-pushed
the
Re-Isearch/add-tests
branch
from
ec6b5f5 to
08fa80c
Compare
fricklerhandwerk
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #571
I tried to make it easy to add tests for further document formats, I hope this isn't overengineered.
I noticed that PDF indexing seemingly doesn't work. The code looks for an external filter tool called
pdftomemo. On re-isearch master, there is an in-tree source checkout ofxpdfat/filters/xpdf-3.01-bsnwhich can build thispdftomemo, but the package in Nixpkgs is too old to have this checkout.Additionally, we do have an
xpdfpackage in Nixpkgs… It is marked insecure due to having multiple known vulnerabilities. And that package has a version number higher than what's included in the repo… So we prolly don't want this anyway.