overview: render subgrant names if they exist in the new project model#581
Merged
Conversation
eljamm
reviewed
Mar 12, 2025
| ${heading 1 name} | ||
| <https://nlnet.nl/project/${name}> | ||
|
|
||
| ${render.subgrants.many (project.metadata.subgrants or [ ])} |
Contributor
There was a problem hiding this comment.
Would it be feasible to fall back to using <https://nlnet.nl/project/${name}> if project.metadata.subgrants doesn't exist? As such, we won't break the links for the old projects.
Contributor
There was a problem hiding this comment.
I think it's okay to break it temporarily (since it's a partial break) and in one of the next steps to invert the compatibility wrapper so //projects-old are converted to the new format.
fricklerhandwerk
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.