services.bonfire: init#1871
Merged
Merged
Conversation
fishinthecalculator
left a comment
There was a problem hiding this comment.
awesome stuff! I have only a small suggestion but in general this looks quite good, thank you!
Contributor
|
Notes from review meeting:
|
8 tasks
2d72ab8 to
cc3c950
Compare
Author
Changes
imports = [
(lib.modules.importApply ../../../../profiles/nixos/nginx/reverse-proxy.nix {
inherit service;
proxyPass = "http://localhost:${toString cfg.settings.SERVER_PORT}";
proxyWebsockets = true;
})
];State
$ nom build -f. hydrated-projects.Bonfire.nixos.tests.basic |
a74af06 to
0245022
Compare
eljamm
reviewed
Jan 28, 2026
eljamm
reviewed
Jan 30, 2026
eljamm
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
services.bonfirewith a relevant example and test.State
It works, but it can still be improved. See inlined comments.
RoadMap
Related but not blocking: security/confidentiality: pinned ranch is too old to support Unix socket permissions bonfire-networks/bonfire-app#1667
meilisearchpostfixRelated
pkgs.bonfire.Relevant commits will be synced with that PR, or dropped whenever it's merged.
Pings