overview: implement the whole project list using modules#1051
Conversation
| in | ||
| { | ||
| options = { | ||
| projectListItems = mkOption { |
There was a problem hiding this comment.
| projectListItems = mkOption { | |
| projects = mkOption { |
Maybe for brevity?
There was a problem hiding this comment.
Sure, but for my understanding: This option interface would be purely about presentation, right? So semantically it would be fine to name it after the UI element?
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Yes, perfect (modulo obligatory nits :P)
Co-authored-by: Valentin Gagarin <valentin@gagarin.work>
Co-authored-by: Valentin Gagarin <valentin@gagarin.work>
Co-authored-by: Valentin Gagarin <valentin@gagarin.work>
|
When building from the PR branch: Can we get this fixed (and also put in order CSS-wise)? Then merge. Yes checks break but this has nothing to do with this PR |
What do you mean with order? It looks like an issue that only occurs when using devmode, should be fine on prod |
Ah, make it abide to the content width and all. But we can fix that later as well. |
2 participants
Is this a correct continuation of your idea, @fricklerhandwerk ?
This is a almost a noop, except for the lastModified timestamp and the commit hash.