Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AWS / GCP types to improve robustness #96

Closed
1 task done
nfroidure opened this issue Nov 6, 2020 · 2 comments
Closed
1 task done

Use AWS / GCP types to improve robustness #96

nfroidure opened this issue Nov 6, 2020 · 2 comments
Labels
enhancement

Comments

@nfroidure
Copy link
Owner

nfroidure commented Nov 6, 2020 •
edited
Loading

nfroidure added a commit that referenced this issue Dec 19, 2020
@nfroidure
refactor(@whook/aws-lambda): refactor lambda triggers
863f9bc 
Refactoring the wrappers to simplify them except for tricky parts like encoding/decoding of events.

BREAKING CHANGE: The consumers do not manage batchs anymore and simply pass the records to the
lambda implementation in order to avoid having to write custom wrappers for each event type. The
user are now free to handle the batchs the way they want.

fix #95 concerns #96
nfroidure added a commit that referenced this issue Dec 19, 2020
@nfroidure
refactor(@whook/aws-lambda): refactor lambda triggers
b290d72 
Refactoring the wrappers to simplify them except for tricky parts like encoding/decoding of events.

BREAKING CHANGE: The consumers do not manage batchs anymore and simply pass the records to the
lambda implementation in order to avoid having to write custom wrappers for each event type. The
user are now free to handle the batchs the way they want.

fix #95 concerns #96
nfroidure added a commit that referenced this issue Dec 19, 2020
@nfroidure
refactor(@whook/aws-lambda): refactor lambda triggers
fbe480b 
Refactoring the wrappers to simplify them except for tricky parts like encoding/decoding of events.

BREAKING CHANGE: The consumers do not manage batchs anymore and simply pass the records to the
lambda implementation in order to avoid having to write custom wrappers for each event type. The
user are now free to handle the batchs the way they want.

fix #95 concerns #96
nfroidure added a commit that referenced this issue Dec 22, 2020
@nfroidure
refactor(@whook/aws-lambda): refactor lambda triggers
f948220 
Refactoring the wrappers to simplify them except for tricky parts like encoding/decoding of events.

BREAKING CHANGE: The consumers do not manage batchs anymore and simply pass the records to the
lambda implementation in order to avoid having to write custom wrappers for each event type. The
user are now free to handle the batchs the way they want.

fix #95 concerns #96
@nfroidure
Copy link
Owner Author

Done for AWS. Waiting for a GCP types module.

@nfroidure
Copy link
Owner Author

Closing in favor of : #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfroidure