Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[neon cluster delete --force] doesn't delete hyper-v cluster in non-admin mode #1896

Closed
jefflill opened this issue Apr 3, 2024 · 1 comment
Closed

[neon cluster delete --force] doesn't delete hyper-v cluster in non-admin mode #1896

jefflill opened this issue Apr 3, 2024 · 1 comment
Assignees
@jefflill
Labels
bug Identifies a bug or other failure neon-cli Neon command line interface tool

Comments

@jefflill
Copy link
Collaborator

jefflill commented Apr 3, 2024

I tried delete a cluster in a non-admin cmd window and the login was removed but the Hyper-V cluster was not impacted. No errors were reported.

We need to do some comprehensive testing in non-admin mode because we generally run our cmd windows as admin.
@jefflill jefflill self-assigned this Apr 3, 2024
@jefflill jefflill added bug Identifies a bug or other failure neon-cli Neon command line interface tool labels Apr 3, 2024
@jefflill
Copy link
Collaborator Author

jefflill commented Apr 3, 2024

FIXED: The problem was that the neon-desktop service wasn't handling the new Notes property passed with the GrpcAddVmRequest.

@jefflill jefflill changed the title [neon cluster delete --force] didn't delete hyper-v cluster in non-admin mode [neon cluster delete --force] doesn't delete hyper-v cluster in non-admin mode Apr 3, 2024
@jefflill jefflill closed this as completed Apr 3, 2024
jefflill added a commit that referenced this issue Apr 3, 2024
@jefflill
#1896: [neon cluster delete --force] doesn't delete hyper-v cluster i…
b58c9f9 
…n non-admin mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jefflill jefflill

Labels
bug Identifies a bug or other failure neon-cli Neon command line interface tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jefflill