Posting to user #24
Open
Posting to user #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 4, 2016 18:12
Change signature of 'listen_for' method by deleting **options signature from it, as it was broken anyway - you had had no option to run this with additional named options, but it was needed to have an ability of pushing options of decorated function. Instead of it some 'academic' code was added - now 'listen_for' method is a decorator factory which returns decorator that have new function declared inside. It allows to push named options of decorated function to it and get rid of wrong signature of factory.
Bot will have an option to post message in channel different than original one it was listened to. To use this ability, you should add 'target_channel' with channel name as an argument of your 'listen_for' decorator.
Bot will have an option to post message directly to some user. To use this ability, you should add 'target_user' with user name as an argument of your 'listen_for' decorator.
sorrowless
force-pushed
the
posting_to_user
branch
from
bbaf226 to
72e5145
Compare
|
I like this idea a lot actually 👍 |
|
@sorrowless @nficano I love this idea. Any chance we have an update on when this can be merged? Looks like there are a few minor conflicts to resolve. |
|
@rmeyer-taos I made that patch long time ago and don't remember too much about that. But if you guys really like that, I'll take a look next week and fix that, np. |
|
No big deal @sorrowless we ended up going a different direction. Thanks for the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot will have an option to post message directly to some user. To use this
ability, you should add 'target_user' with user name as an argument of your
'listen_for' decorator.