Posting to another channel #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2016 18:12
Change signature of 'listen_for' method by deleting **options signature from it, as it was broken anyway - you had had no option to run this with additional named options, but it was needed to have an ability of pushing options of decorated function. Instead of it some 'academic' code was added - now 'listen_for' method is a decorator factory which returns decorator that have new function declared inside. It allows to push named options of decorated function to it and get rid of wrong signature of factory.
Bot will have an option to post message in channel different than original one it was listened to. To use this ability, you should add 'target_channel' with channel name as an argument of your 'listen_for' decorator.
|
@sorrowless what's the use case for this? |
|
@nficano for creating bot only channels, of course :) |
|
This seems like a reasonable feature to have. For instance, you could have a channel where all the links posted on different channels could be aggregated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot will have an option to post message in channel different than original
one it was listened to. To use this ability, you should add
'target_channel' with channel name as an argument of your 'listen_for'
decorator.