Teams notifications #1717
Merged
Teams notifications #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is Slack also supported? I haven't checked but it had a feeling it was? |
|
Yes, slack should also be supported. If I'm not mistaken |
|
The selection for slack vs teams is done based on the url So the method for enabling the notification stays the same. |
|
the docs for slack are here So if you were to add that next to the teams ones I think it's good to go |
|
I agree with @matthdsm |
matthdsm
approved these changes
Mar 29, 2023
|
Thanks for the review @matthdsm @muffato @christopher-hakkaart :) |
muffato
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1455 but I need feedback if this is correct and also if this page is appropriate.