Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline health: Check default branch #2859

Closed
ewels opened this issue Nov 21, 2024 · 0 comments · Fixed by #2865
Closed

Pipeline health: Check default branch #2859

ewels opened this issue Nov 21, 2024 · 0 comments · Fixed by #2865
Labels
automation Automation tasks enhancement New feature or request

Comments

@ewels
Copy link
Member

ewels commented Nov 21, 2024

Description of feature

Follow on from: nf-core/tools#1931

We already check the default branch in pipeline health, this needs updating to look for manifest.defaultBranch in the pipeline code to make sure that they match.

Should be a warning if master, pass if main and fail if not matching, or anything else. dev before first release is fine.
@ewels ewels added automation Automation tasks enhancement New feature or request labels Nov 21, 2024
@ewels ewels transferred this issue from nf-core/tools Nov 21, 2024
@mashehu mashehu mentioned this issue Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation Automation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add manifest to pipelines.json, add manifest.default_branch to mashehu/nf-co.re
1 participant
@ewels