Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main instead of master for branch name when generating a new pipeline? #1931

Closed
lucacozzuto opened this issue Oct 11, 2022 · 6 comments · Fixed by #3142
Closed

Main instead of master for branch name when generating a new pipeline? #1931

lucacozzuto opened this issue Oct 11, 2022 · 6 comments · Fixed by #3142
Assignees
Milestone

Comments

@lucacozzuto
Copy link

Is your feature request related to a problem? Please describe

I'm setting up a new local pipeline and I got three branches. I think the master one should be replaced by main...

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@lucacozzuto lucacozzuto changed the title [FEATURE] Main instead of master for branch name when generating a new pipeline? Oct 11, 2022
@edmundmiller edmundmiller transferred this issue from nf-core/modules Oct 11, 2022
@edmundmiller
Copy link
Contributor

I believe @ewels and others were opposed as it would break a lot of things.
See https://nfcore.slack.com/archives/C0448VBG30R/p1664972715894999

@maxulysse
Copy link
Member

I'd love to see that, but for the moment, master is still hardcoded in a lot of places.
It's on our TODO list, definitively, and I'm quite adamant on having that pushed.

@ewels
Copy link
Member

ewels commented Sep 26, 2024

We will merge in support for using main for tools v3 and mention it in the release. But not take any action immediately (the code will support both main and master).

Once the dust has settled we will have a dedicated blog post about the switch, and then start going through all nf-core org repos making the change.

@mirpedrol
Copy link
Member

Moving this issue to the next milestone until nextflow-io/nextflow#3593 is fixed by Nextflow

@mirpedrol mirpedrol modified the milestones: 3.0, 3.1 Oct 1, 2024
@ewels
Copy link
Member

ewels commented Nov 21, 2024

The above is now resolved and in stable, so shouldn't be a blocker any more.

@ewels
Copy link
Member

ewels commented Nov 21, 2024

Let's still set manifest.defaultBranch to main as well. Should make it work in older versions of Nextflow and is the most paranoid approach.

https://www.nextflow.io/docs/latest/reference/config.html#manifest

It's verbose is the only downside, but we're templating. Can remove in a year or once everyone is running > 24.10.0 if we like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

6 participants