-
Notifications
You must be signed in to change notification settings - Fork 218
Issues/3466 Move away from Gitpod #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 157 commits
Commits
Show all changes
172 commits
Select commit
Hold shift + click to select a range
80b0182
Renaming Dockerfile and location. Changing to building the Dockerfile…
JulianFlesch 7a8cebd
change Container user. Change base Image for devcontainer
JulianFlesch 5fd706a
Remove installation of apptainer via apt-get because of 404 from ppa
JulianFlesch 0d6e6a5
Create unprivileged user
JulianFlesch be2996e
Change git workflow for container creation and use the correct contai…
JulianFlesch 53dd172
Update instruction to build locally for testing
JulianFlesch dd6ddc3
[automated] Update CHANGELOG.md
nf-core-bot 0c3a21d
Merge branch 'issues/3466-gitpod' of github.com:JulianFlesch/nf-core-…
JulianFlesch 464d3bd
More descriptive changelog entry
JulianFlesch 2ee5fc1
Change base Image
JulianFlesch 776b2c8
Change back to using gitpod user
JulianFlesch a5c6644
Remove comment
JulianFlesch c77a469
WIP: build container locally instead of pulling. Change to gitpod use…
JulianFlesch 36e5f7a
Rename pushed container to nf-core/devcontainer
JulianFlesch 4f8a2c0
Remove gitpod.yml from template
JulianFlesch c225114
Remove .gitpod.yml
JulianFlesch 56962f2
Merge branch 'dev' into issues/3466-gitpod
JulianFlesch f525657
Remove local container building
JulianFlesch e0e6d97
Change base image tag
JulianFlesch 923d99d
re-add comments
JulianFlesch b5e7487
Add latest tag explicitly
JulianFlesch 8785edb
Test seqera container base image
JulianFlesch cccb21c
update comments. todo
JulianFlesch 774b4cd
Rename to reflect base image
JulianFlesch 0091a34
WIP: devcontainer with docker-in-docker feature
JulianFlesch 875d661
Add seqera url as comment
JulianFlesch 6a2c92d
Overwrite base image entrypoint. Add non-privileged user.
JulianFlesch 77a8357
Clean up
JulianFlesch 0aa49b3
Make user privileged when running container
JulianFlesch e9fa6df
Change to non-root user 'vscode' from base image. Try running without…
JulianFlesch 552b0ff
Run privileged
JulianFlesch dd021d0
Change nf-core install to have dev dependencies and --editable set
JulianFlesch 64e86d5
Install pre-commit hooks in image
JulianFlesch 9eda307
Remove redundant post-create installation of nf-core and pre-commit h…
JulianFlesch d0fea24
Remove postCreateCommand. Remove Privileged
JulianFlesch d974952
Fix pre-commit install cmd
JulianFlesch 3216521
Remove more redundant conda packages
JulianFlesch e400076
Chown nf-core dir when copying. Chown conda folder only when using conda
JulianFlesch 7e1aba2
Remove unneeded dependencies and those already in base image
JulianFlesch 14a3e95
Fix command end
JulianFlesch 6d284fb
WIP: Comment out section adding lots of size to the image
JulianFlesch 5d8503b
Use vscode user everywhere
JulianFlesch 08d29fc
Re-introduce nextflow update, nf-core dev, and commit hooks install
JulianFlesch c5dd2d2
Use nextflow/training base image to share nextflow, conda installation
JulianFlesch 0fa9993
Add setup.sh to fix run issues with nf/training img. Move latest tool…
JulianFlesch 2eceaf7
change ownership of nextflow installation location
JulianFlesch 4b825df
Update comment. Change layer order
JulianFlesch d7854ff
Update template devcontainer
JulianFlesch 3dff96d
Remove testing Dockerfiles
JulianFlesch 4e9d298
Merge branch 'dev' into issues/3466-gitpod
JulianFlesch a7b5c48
Fix base image version
JulianFlesch 4a55651
Fix sha typo
JulianFlesch cd292aa
WIP: Build locally for testing image changes
JulianFlesch 2f55746
Remove container build
JulianFlesch df3bd4b
Change to root user
JulianFlesch 7de59cb
Add apptainer as local feature
JulianFlesch fb5ca93
Use existing tutorial baseimage and instead mount current folder.
JulianFlesch 403f3e3
Remove docker-in-docker feature to avoid interference with parent fea…
JulianFlesch 24a05c7
Change container prompt to cope with long paths
JulianFlesch c00b89a
update welcome message
JulianFlesch 0398115
Remove obsolete Dockerfile
JulianFlesch d99a896
Change template devcontainer to reuse training base image, fix docker…
JulianFlesch 65e8cb4
Custom prompt to cope with long paths. Updates welcome message
JulianFlesch 19066ee
Custom prompt to cope with long paths. Updates welcome message
JulianFlesch d82eac5
Add nf-core, pre-commit hook install to setup. Update welcome message
JulianFlesch 685a8d8
Add local features nf-test, apptainer. (Util fixed in parent)
JulianFlesch def9bf2
Add nf-test also to tools devcontainer as local feature
JulianFlesch 4918d6c
Adapt git workflow to build with devcontainer ci
JulianFlesch b1079a5
Adds devcontaner config for building.
JulianFlesch 9a9c266
Simplified devcontainer config for running. Removes all feature insta…
JulianFlesch 5622095
Change workflow for release to build with devcontainer ci
JulianFlesch 491ec95
Change to using prebuild image. Remove local feature installs. Simpli…
JulianFlesch 2308afc
Fix devcontainers/ci version by sha
JulianFlesch 355f913
Testing: run workflow on personal feature branch temporarily
JulianFlesch e1fcc09
Testing: Add workflow_dispatch to run wf manually
JulianFlesch 8559593
Testing: Remove repo constraint
JulianFlesch ce0cf88
Move local features into build-devcontainer
JulianFlesch 22bbccf
Use no cache for build
JulianFlesch ca5fba7
testing buildx config
JulianFlesch 60a0154
Testing container deploy
JulianFlesch 66755be
Testing deployed image in codespaces
JulianFlesch b9a5e94
Testing: Limit to only devcontainer image build+push
JulianFlesch 6febca6
Test tools build + upload
JulianFlesch 67bb3d6
Use devcontainer-cli to run build
JulianFlesch 4e38437
Fix workflow
JulianFlesch 89c06c3
testing: devcontainer ci build with manual comand
JulianFlesch fb7af6e
Revert to using devcontainers/ci action. Remove imageTag
JulianFlesch 50a157e
Testing auto pushing
JulianFlesch 363c702
Testing manual push
JulianFlesch fa096bc
Revert "Testing manual push"
JulianFlesch 386d37a
Improve naming. Reorder Steps for readability
JulianFlesch acd7af3
Update devcontainers build and push in release workflow.
JulianFlesch 7ee9751
Update comment
JulianFlesch fee17eb
Changes for manually testing release workflow
JulianFlesch 361a0c3
revert changing workflow trigger
JulianFlesch 2ad4f37
Add docker buildx to fix oci builds error
JulianFlesch 01b2f49
Fix testing registry names
JulianFlesch af6b3e6
Testing action/checkout with push hook
JulianFlesch 171b31f
Testing action/checkout with push hook
JulianFlesch a7f2fb6
Testing: Run on push to dev
JulianFlesch 1af5545
Change path of setup script
JulianFlesch 2645a76
Change container tag for testing
JulianFlesch 11a79b3
Don't run any commands for testing
JulianFlesch 09a1bb8
Fix nf-test download in tools Dockerfile
JulianFlesch d748c35
Add nextflow feature
JulianFlesch d36f5af
Adds local and public featuers to config
JulianFlesch 20ce3f3
Remove redundant nf-test install
JulianFlesch b494895
Move tools installation to Dockerfile to install version in current w…
JulianFlesch a6958a3
Clean unused line
JulianFlesch fa91962
Run setup.sh on devcontainer startup with nextflow update, prompt con…
JulianFlesch 70a66cb
adds workflow_dispatch trigger
JulianFlesch 99c701c
Add qemu action for multi platform build
JulianFlesch 4316c6d
Change call to setup.sh and make it executable
JulianFlesch 85e2572
Test building nfcore-tools image for more platforms
JulianFlesch c8c3db4
Use buildx for nfcore tools image
JulianFlesch 47b8e5d
Use buildx for multi-platform build and to handle push. Use login-act…
JulianFlesch ccc72b7
Fix secrets
JulianFlesch 3a53655
Add targets to buildx
JulianFlesch 365a1fb
Fix build command
JulianFlesch 5258b94
Test using variable
JulianFlesch 0be623a
Fix reference to env variables
JulianFlesch adfd85e
Fix actions version to sha
JulianFlesch 45050e9
Update release workflow for testing
JulianFlesch 4c758ba
Change to installing nf-test via conda in devcontainer
JulianFlesch 333bcab
Remove post install commands for nf-test
JulianFlesch 11d1337
Remove unused local feature
JulianFlesch 1234279
Adds retry for tools image build
JulianFlesch 7fee45c
Fix retry time
JulianFlesch 18f51e5
Adds required field
JulianFlesch bd96723
Lower tools image build timeout. Retry on error+timeout (default)
JulianFlesch 58af5d6
Revert testing config
JulianFlesch 16a0a5a
Adapt timeout to have more leeway
JulianFlesch 3be9da3
Merge changes from dev
JulianFlesch bce4da7
Move changes to 3.4.0dev
JulianFlesch bc08cfc
Remove local features from pipeline template
JulianFlesch f5d072c
Update .devcontainer/setup.sh welcome text
JulianFlesch 6d0ebd9
Add ruff formatter to extensions list
JulianFlesch fc27a21
Merge branch 'issues/3466-gitpod' of github.com:JulianFlesch/nf-core-…
JulianFlesch 8a29fe4
Add explicit versioning of features
JulianFlesch d19c681
Fix typo
JulianFlesch bfa7fc0
Fix feature versioning
JulianFlesch 15458e4
Remove gitpod from template_features
JulianFlesch 303d6bc
Add jinja variable for pipelien name to greeting
JulianFlesch c2acb3a
Adapt feature install for debian based image
JulianFlesch 34667b0
Change to using miniconda base image to avoid python version conflict…
JulianFlesch 8ba78cb
Fix typo
JulianFlesch df6520f
Move extension install to parent container.
JulianFlesch 98f0eb3
Clean up redundant config section.
JulianFlesch 7bc7fff
Merge current dev
JulianFlesch d747823
WIP: Fix tests
JulianFlesch d3a465b
Add setup.sh linter exception. don't expect any .devcotonainer files …
JulianFlesch 6d8c9ba
Add snapshots to fix tests with changed template_features.
JulianFlesch f2ed52a
Remove mounting localWorkspaceFolder due to issues in Codespaces.
JulianFlesch 20e8388
Use other base image for testing
JulianFlesch ef51e49
Remove localWorkspaceFolder mounting
JulianFlesch 3008aae
Update comment
JulianFlesch 4cef0dc
Revert "Use other base image for testing"
JulianFlesch ac8b88c
Remove checking for devcontainer files
JulianFlesch c83bd63
Merge dev changes. Update test_create_app snapshots
JulianFlesch f772a74
Use tag 'latest', since sha updates would be out dated with current w…
JulianFlesch b7672cc
Removes hook from no longer used feature
JulianFlesch f85bbbf
Merge branch 'dev' into issues/3466-gitpod
JulianFlesch 063ec8b
Merge branch 'dev' into issues/3466-gitpod
JulianFlesch 73bd04b
Merge branch 'issues/3466-gitpod' of github.com:JulianFlesch/nf-core-…
JulianFlesch 717fd8e
fix tests: Update snapshots
JulianFlesch fce08cf
impr: Cleanup after pip and conda
JulianFlesch 04c14dd
impr: Move nf-test and nextflow install to Dockerfile to reduce their…
JulianFlesch 5fb202d
impr: Add two-stage build to only keep essential files
JulianFlesch 86b1976
fix typo: remove duplicate line
JulianFlesch b4335b2
impr: Move apptainer install to Dockerfile to improve container size
JulianFlesch 6c1596c
cleanup: remove unused features and update comments
JulianFlesch 285a2a1
impr: Use more lean base image for final stage.
JulianFlesch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # devcontainers/miniconda image based on debian (bookworm) | ||
| # see tags and images: https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/miniconda/tags | ||
| FROM "mcr.microsoft.com/devcontainers/miniconda@sha256:8e262a2664fab1d53054738d3633338558a2078ce66d3abde55c130f0d5da94f" | ||
|
|
||
| # copy this repo at current revision | ||
| COPY . /root/nfcore-tools/ | ||
|
|
||
| # Explicitly reinstall python 3.13 via conda | ||
| # install local nf-core tools version, and precommit hooks | ||
| RUN cd /root/nfcore-tools/ && \ | ||
| conda install -y python=3.13 && \ | ||
| pip install --no-cache-dir --upgrade pip setuptools wheel pre-commit && \ | ||
| pip install -r requirements.txt -e . --no-cache-dir && \ | ||
| pre-commit install --install-hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| { | ||
| "name": "nfcore-devcontainer-build", | ||
|
|
||
| // installs python3.13, nf-core tools from current workspace | ||
| // based on mcr.microsoft.com/devcontainers/miniconda image | ||
| "build": { | ||
| "dockerfile": "./Dockerfile", | ||
| "context": "../.." | ||
| }, | ||
|
|
||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-outside-of-docker:1.6.3": {}, | ||
| "ghcr.io/devcontainers/features/java:1.6.3": { | ||
| "version": "21.0.6-ms" | ||
| }, | ||
| "./local-features/apptainer": {}, | ||
| "./local-features/nextflow": {} | ||
| }, | ||
|
|
||
| "remoteEnv": { | ||
| "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" | ||
| }, | ||
|
|
||
| "remoteUser": "root", | ||
| "privileged": true, | ||
|
|
||
| // Configure tool-specific properties. | ||
| "customizations": { | ||
| // Configure properties specific to VS Code. | ||
| "vscode": { | ||
| // Set *default* container specific settings.json values on container create. | ||
| "settings": { | ||
| "python.defaultInterpreterPath": "/opt/conda/bin/python" | ||
| }, | ||
|
|
||
| // Add the IDs of extensions you want installed when the container is created. | ||
| "extensions": [ | ||
| "charliermarsh.ruff", | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance", | ||
| "nf-core.nf-core-extensionpack" | ||
| ] | ||
| } | ||
| } | ||
| } |
5 changes: 5 additions & 0 deletions
5
.devcontainer/build-devcontainer/local-features/apptainer/devcontainer-feature.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "id": "apptainer", | ||
| "name": "Install Apptainer", | ||
| "version": "1.0.0" | ||
| } |
18 changes: 18 additions & 0 deletions
18
.devcontainer/build-devcontainer/local-features/apptainer/install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Install Apptainer (Singularity) | ||
|
|
||
| apt-get update --quiet | ||
|
|
||
| # apptainer installer dependencies | ||
| apt-get install -y curl rpm2cpio cpio | ||
|
|
||
| # install from pre-built binaries | ||
| # see: https://apptainer.org/docs/admin/main/installation.html#install-unprivileged-from-pre-built-binaries | ||
| curl -s https://raw.githubusercontent.com/apptainer/apptainer/main/tools/install-unprivileged.sh | bash -s - /usr/local/apptainer | ||
|
|
||
| # add /usr/local/apptainer/bin to path | ||
| echo "PATH=/usr/local/apptainer/bin:$PATH" >> $HOME/.bashrc | ||
|
|
||
| apt-get clean | ||
| rm -rf /var/lib/apt/lists/* |
7 changes: 7 additions & 0 deletions
7
.devcontainer/build-devcontainer/local-features/nextflow/devcontainer-feature.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "id": "nextflow", | ||
| "name": "Nextflow Installation", | ||
| "description": "Install Nextflow and nf-test", | ||
| "version": "1.0.0", | ||
| "installsAfter": ["ghcr.io/devcontainers/features/java:1", "ghcr.io/rocker-org/devcontainer-features/miniforge:2"] | ||
| } |
50 changes: 50 additions & 0 deletions
50
.devcontainer/build-devcontainer/local-features/nextflow/install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eux | ||
| USERNAME="${USERNAME:-"${_REMOTE_USER:-"automatic"}"}" | ||
| NEXTFLOW_INSTALL_DIR=/usr/local/bin | ||
|
|
||
| if [ "$(id -u)" -ne 0 ]; then | ||
| echo -e 'Script must be run as root. Use sudo, su, or add "USER root" to your Dockerfile before running this script.' | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Determine the appropriate non-root user | ||
| if [ "${USERNAME}" = "auto" ] || [ "${USERNAME}" = "automatic" ]; then | ||
| USERNAME="" | ||
| POSSIBLE_USERS=("vscode" "node" "codespace" "$(awk -v val=1000 -F ":" '$3==val{print $1}' /etc/passwd)") | ||
| for CURRENT_USER in "${POSSIBLE_USERS[@]}"; do | ||
| if id -u ${CURRENT_USER} > /dev/null 2>&1; then | ||
| USERNAME=${CURRENT_USER} | ||
| break | ||
| fi | ||
| done | ||
| if [ "${USERNAME}" = "" ]; then | ||
| USERNAME=root | ||
| fi | ||
| elif [ "${USERNAME}" = "none" ] || ! id -u ${USERNAME} > /dev/null 2>&1; then | ||
| USERNAME=root | ||
| fi | ||
|
|
||
| # Add the nextflow group if it doesn't exist | ||
| if ! cat /etc/group | grep -e "^nextflow:" > /dev/null 2>&1; then | ||
| groupadd -r nextflow | ||
| fi | ||
| # Add the user to the nextflow group | ||
| usermod -a -G nextflow "${USERNAME}" | ||
|
|
||
| # Install Nextflow | ||
| echo "Installing Nextflow..." | ||
| cd $NEXTFLOW_INSTALL_DIR | ||
| curl -s https://get.nextflow.io | bash | ||
|
|
||
| # Install nf-test via conda | ||
| echo "Installing nf-test..." | ||
| conda install -y -c bioconda nf-test | ||
|
|
||
| # Set ownership and permissions on the nextflow executable | ||
| chown "${USERNAME}:nextflow" "${NEXTFLOW_INSTALL_DIR}"/nextflow | ||
| chmod g+r+w "${NEXTFLOW_INSTALL_DIR}"/nextflow | ||
| #find "${NEXTFLOW_INSTALL_DIR}" -type d -print0 | xargs -n 1 -0 chmod g+s | ||
|
|
||
| echo "Done!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,14 @@ | ||
| { | ||
| "name": "nfcore", | ||
| "image": "nfcore/gitpod:latest", | ||
| "postCreateCommand": "python -m pip install --upgrade -r ../requirements-dev.txt -e ../ && pre-commit install --install-hooks", | ||
| "remoteUser": "gitpod", | ||
| "runArgs": ["--privileged"], | ||
| "image": "nfcore/devcontainer:latest", // ToDo: Add version hash once available | ||
|
|
||
| // Configure tool-specific properties. | ||
| "customizations": { | ||
| // Configure properties specific to VS Code. | ||
| "vscode": { | ||
| // Set *default* container specific settings.json values on container create. | ||
| "settings": { | ||
| "python.defaultInterpreterPath": "/opt/conda/bin/python" | ||
| }, | ||
| "remoteEnv": { | ||
| // Workspace path on the host for mounting with docker-outside-of-docker | ||
| "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" | ||
| }, | ||
|
|
||
| // Add the IDs of extensions you want installed when the container is created. | ||
| "extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"] | ||
| } | ||
| } | ||
| "onCreateCommand": "./.devcontainer/setup.sh", | ||
|
|
||
| "remoteUser": "root", | ||
| "privileged": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Customise the terminal command prompt | ||
| echo "export PROMPT_DIRTRIM=2" >> $HOME/.bashrc | ||
| echo "export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '" >> $HOME/.bashrc | ||
| export PROMPT_DIRTRIM=2 | ||
| export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] ' | ||
|
|
||
| # Update Nextflow | ||
| nextflow self-update | ||
|
|
||
| # Update welcome message | ||
| echo "Welcome to the nf-core devcontainer!" > /usr/local/etc/vscode-dev-containers/first-run-notice.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay realizing what repo we're in now. We can probably consolidate these, and clean it up and it can stay on dockerhub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to push this to Dockerhub? Could we use ghcr.io or quay.io?