Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new error message pointing to docs when 'requirement exceeds available memory' error message #2688

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Add new error message pointing to docs when 'requirement exceeds available memory' error message #2688

merged 5 commits into from
Jan 26, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 26, 2024 •
edited
Loading

<3 to @mribeirodantas for the solution on the Nextflow discourse!

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 changed the base branch from master to dev January 26, 2024 08:49
@github-actions GitHub Actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/nf-core-tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/nf-core-tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

jfy133
jfy133 commented Jan 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 jfy133 requested review from mashehu and mirpedrol January 26, 2024 08:50
mashehu
mashehu approved these changes Jan 26, 2024
View reviewed changes
nf_core/pipeline-template/workflows/pipeline.nf Outdated
workflow.onError {
if (workflow.errorReport.contains("Process requirement exceeds available memory")) {
println("🛑 Default resources exceed availability 🛑 ")
println "💡 See here on how to configure pipeline: https://nf-co.re/docs/usage/configuration#tuning-workflow-resources 💡"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two different syntax styles?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how that happened!

@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (011f3ac) 73.41% compared to head (855e22e) 73.47%.
Report is 4 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfy133 jfy133 merged commit 996c54b into nf-core:dev Jan 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@mirpedrol mirpedrol Awaiting requested review from mirpedrol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @mashehu