add mypy to pre-commit config, fix mypy errors #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2545 +/- ##
==========================================
- Coverage 74.97% 74.93% -0.05%
==========================================
Files 85 85
Lines 9215 9215
==========================================
- Hits 6909 6905 -4
- Misses 2306 2310 +4 ☔ View full report in Codecov by Sentry. |
mirpedrol
approved these changes
Nov 28, 2023
| @@ -599,7 +599,7 @@ def remote(ctx, keywords, json): | |||
| default=".", | |||
| help=r"Pipeline directory. [dim]\[default: Current working directory][/]", | |||
| ) | |||
| def local(ctx, keywords, json, dir): # pylint: disable=redefined-builtin | |||
| def modules_list_local(ctx, keywords, json, dir): # pylint: disable=redefined-builtin | |||
There was a problem hiding this comment.
should we do these changes for subworkflows too?
mypy.ini
Outdated
There was a problem hiding this comment.
Why can't we have this in pyproject.toml?
There was a problem hiding this comment.
it felt like it didn't pick it up correctly. let me check again
…ommit # Conflicts: # .github/workflows/pytest.yml
This reverts commit ae505c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.