Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate component create to nf test #2490

Merged
merged 119 commits into from
Nov 21, 2023
Merged

Migrate component create to nf test #2490

merged 119 commits into from
Nov 21, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 24, 2023 •
edited
Loading

  • nf-core modules create
  • nf-core subworkflows create
  • nf-core modules create-nf-test
  • nf-core subworkflows create-nf-test

bonus points:

  • nf-core modules create-nf-test --migrate
  • nf-core subworkflows create-nf-test --migrate

mirpedrol
mirpedrol reviewed Oct 24, 2023
View reviewed changes
nf_core/utils.py Outdated Show resolved Hide resolved
@mashehu mashehu mentioned this pull request Oct 24, 2023
Closed
mashehu and others added 21 commits October 24, 2023 17:24
@mashehu
replace params
86613b6
@mashehu
fix typing errors
e0c30cd
@mirpedrol
add TODO comments to main.nf.test and fix tags.yml template rendering
a9f55ba
@mirpedrol
add todo comment for chained modules
865d613
@mirpedrol
add real example to main.nf.test
d767c78
@mirpedrol
add tags.yml to prettierignore
876eab3
@mirpedrol
add main.nf.test to template instead of using nf-test
3b9f031
@mashehu @mirpedrol
generalize nextflow_cmd to run_cmd to use the same structure for nf-test
79215fb
@mashehu @mirpedrol
initial changes for nf-test
7cab286
@mashehu @mirpedrol
move tags.yml to correct position
f41d410
@mashehu @mirpedrol
convert all cmds
cbc398a
@mashehu @mirpedrol
first running version
8d7794a
@mashehu @mirpedrol
replace params
1a58690
@mashehu @mirpedrol
fix typing errors
86db72b
@mirpedrol
add TODO comments to main.nf.test and fix tags.yml template rendering
7a7fd93
@mirpedrol
add todo comment for chained modules
11773ef
@mirpedrol
add real example to main.nf.test
eafb3b5
@mirpedrol
add tags.yml to prettierignore
56086c6
@mirpedrol
add main.nf.test to template instead of using nf-test
63c3188
@mirpedrol
modules create tests check for main.nf.test
4038131
@mirpedrol
remove outputDir from the modules template
43bf218
mirpedrol
mirpedrol reviewed Nov 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mashehu
mashehu commented Nov 21, 2023
View reviewed changes
nf_core/components/components_test.py Show resolved Hide resolved
nf_core/components/components_test.py Outdated Show resolved Hide resolved
nf_core/components/components_test.py Outdated Show resolved Hide resolved
nf_core/modules/lint/module_tests.py Show resolved Hide resolved
@mashehu mashehu merged commit 4093f87 into nf-core:dev Nov 21, 2023
19 checks passed
@mashehu mashehu deleted the migrate-component-create-to-nf_test branch November 21, 2023 11:40
@mashehu mashehu mentioned this pull request Jan 9, 2024
Closed
4 tasks
This was referenced Jan 22, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk left review comments

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nvnieuwk