-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deprecation warnings for python and github actions #1998
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1998 +/- ##
==========================================
+ Coverage 62.49% 63.37% +0.88%
==========================================
Files 43 44 +1
Lines 4901 5030 +129
==========================================
+ Hits 3063 3188 +125
- Misses 1838 1842 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes! 😃
On a sidenote: it would be neat to have PR's for a single purpose. I see two major themes in this one: the first is the dependency change from imghdr to filetype and the second is the actions update.
Yep, my bad. 😞 |
@mashehu There was no intention to shame you. And there's no need to feel bad about it. We all did that a lot and still do it more or less often - and I think it makes sense to now and then trow in a reminder - not just for the author of a PR but all the readers (including me) 😺 |
It is. It will be fixed in the next isort-action release. |
Python:
imghdr -> filetype [PEP-594](https://peps.python.org/pep-0594/#imghdr
GH-Actions:
update
upload-artifact
,isort-action
,setup-node
,setup-python
switch to new style for
::set-output