Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation warnings for python and github actions #1998

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 4, 2022

Python:
imghdr -> filetype [PEP-594](https://peps.python.org/pep-0594/#imghdr

GH-Actions:
update upload-artifact, isort-action, setup-node, setup-python
switch to new style for ::set-output

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1998 (ca63f06) into dev (5c0d98b) will increase coverage by 0.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1998      +/-   ##
==========================================
+ Coverage   62.49%   63.37%   +0.88%     
==========================================
  Files          43       44       +1     
  Lines        4901     5030     +129     
==========================================
+ Hits         3063     3188     +125     
- Misses       1838     1842       +4     
Impacted Files Coverage Δ
nf_core/components/components_command.py 67.92% <0.00%> (-16.60%) ⬇️
nf_core/__main__.py 59.59% <0.00%> (-0.41%) ⬇️
nf_core/components/list.py 69.62% <0.00%> (ø)
nf_core/modules/modules_repo.py 81.46% <0.00%> (+2.05%) ⬆️
nf_core/subworkflows/install.py 85.00% <0.00%> (+62.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@fabianegli fabianegli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! 😃

On a sidenote: it would be neat to have PR's for a single purpose. I see two major themes in this one: the first is the dependency change from imghdr to filetype and the second is the actions update.

@mashehu
Copy link
Contributor Author

mashehu commented Nov 4, 2022

On a sidenote: it would be neat to have PR's for a single purpose. I see two major themes in this one: the first is the dependency change from imghdr to filetype and the second is the actions update.

Yep, my bad. 😞
BTW the isort job still throws the ::set-output warning, but I think that it is coming from isort-action.

@mashehu mashehu merged commit 15b2066 into nf-core:dev Nov 4, 2022
@mashehu mashehu deleted the update-deps branch November 4, 2022 12:15
@fabianegli
Copy link
Contributor

@mashehu There was no intention to shame you. And there's no need to feel bad about it. We all did that a lot and still do it more or less often - and I think it makes sense to now and then trow in a reminder - not just for the author of a PR but all the readers (including me) 😺

@fabianegli
Copy link
Contributor

fabianegli commented Nov 4, 2022

BTW the isort job still throws the ::set-output warning, but I think that it is coming from isort-action.

It is. It will be fixed in the next isort-action release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants