Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception in nf-core list when a broken git repo is found #1445

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 14, 2022

Closes #1273

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels linked an issue Mar 14, 2022 that may be closed by this pull request
@@ -374,13 +374,13 @@ def get_local_nf_workflow_details(self):
self.active_tag = str(tag)

# I'm not sure that we need this any more, it predated the self.branch catch above for detacted HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment still valid?

Co-authored-by: Matthias Hörtenhuber <[email protected]>
@ewels ewels merged commit 41b93e2 into nf-core:dev Mar 14, 2022
@ewels ewels deleted the fix-list-broken-repo branch March 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-core list throws InvalidGitRepositoryError error
2 participants