Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run nextflow self-update in CI tests #1362

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 14, 2021

Don't run nextflow self-update in CI tests. Should fix #1361

Also, move static env vars to top level of the workflow.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Also, move static env vars to top level of the workflow.
@ewels ewels requested review from drpatelh and grst December 14, 2021 13:30
@ewels
Copy link
Member Author

ewels commented Dec 14, 2021

Tested on the RNA-seq pipeline here: nf-core/rnaseq#736

Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ggabernet
Copy link
Member

It works on the test pipeline: https://github.com/nf-core/testpipeline/actions/runs/1578161310

@drpatelh
Copy link
Member

Awesome!

@drpatelh drpatelh merged commit 19ffbcb into nf-core:dev Dec 14, 2021
@ewels ewels deleted the fix-ci-nxf-version branch December 14, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants