Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in nf-core list when NXF_HOME is set #1299

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Oct 26, 2021

Minor bugfix in nf-core list where the pipeline directory was not set when using the NXF_HOME environment variable.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1299 (3f2581d) into dev (9a8572b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1299      +/-   ##
==========================================
+ Coverage   67.52%   67.54%   +0.01%     
==========================================
  Files          50       50              
  Lines        5607     5607              
==========================================
+ Hits         3786     3787       +1     
+ Misses       1821     1820       -1     
Impacted Files Coverage Δ
nf_core/list.py 80.65% <0.00%> (ø)
nf_core/modules/lint/main_nf.py 82.75% <0.00%> (-2.07%) ⬇️
nf_core/modules/lint/__init__.py 84.18% <0.00%> (+1.39%) ⬆️
nf_core/modules/lint/module_version.py 84.61% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca734b...3f2581d. Read the comment docs.

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@drpatelh drpatelh merged commit 15e025d into nf-core:dev Oct 26, 2021
@ewels ewels deleted the list-nxf-home-bug branch October 27, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants