Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_wf_use_local_configs #1298

Merged
merged 3 commits into from
Nov 1, 2021
Merged

fix test_wf_use_local_configs #1298

merged 3 commits into from
Nov 1, 2021

Conversation

bunop
Copy link
Contributor

@bunop bunop commented Oct 22, 2021

Dear developers,

This PR will solve #1296 (test_wf_use_local_configs is not working as expected) by disabling caching config during test

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

bunop added 3 commits October 22, 2021 17:25
suppress 'DeprecationWarning: invalid escape sequence \.' by using patterns explicitely
tests/test_download.py::DownloadTest::test_wf_use_local_configs was failing forever after first attempt since the first attempt cached a configuration file which is reloaded in all the following cases. Now we disable caching in $HOME/.nextflow/nf-core while during tests
@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #1298 (d07653b) into dev (9a8572b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1298      +/-   ##
==========================================
+ Coverage   67.52%   67.55%   +0.03%     
==========================================
  Files          50       50              
  Lines        5607     5610       +3     
==========================================
+ Hits         3786     3790       +4     
+ Misses       1821     1820       -1     
Impacted Files Coverage Δ
nf_core/download.py 55.20% <100.00%> (+0.21%) ⬆️
nf_core/utils.py 84.50% <100.00%> (+0.03%) ⬆️
nf_core/modules/lint/main_nf.py 82.75% <0.00%> (-2.07%) ⬇️
nf_core/modules/lint/__init__.py 84.18% <0.00%> (+1.39%) ⬆️
nf_core/modules/lint/module_version.py 84.61% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca734b...d07653b. Read the comment docs.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot, thanks!

@ewels ewels merged commit e9b6c63 into nf-core:dev Nov 1, 2021
@bunop bunop deleted the test_download_bug branch October 28, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants