Update modules in pipeline template with new versions syntax #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseEspinosa
approved these changes
Oct 1, 2021
Comment on lines
+25
to
+27
| path "software_versions.yml" , emit: yml | ||
| path "software_versions_mqc.yml", emit: mqc_yml | ||
| path "versions.yml" , emit: versions |
There was a problem hiding this comment.
I also saw this change in the modules repo, just curious, shouldn't they be single quotes since there is any interpolation inside?
There was a problem hiding this comment.
I think they were auto-formatted somehow 👀
|
I just saw the error, we need to include |
JoseEspinosa
requested changes
Oct 1, 2021
JoseEspinosa
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
I just commit the change and now test are passing, feel free to merge @drpatelh 🍬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting fixes from nf-core/modules#780