Fix #1275 #1278
Merged
Fix #1275 #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grst
reviewed
Sep 29, 2021
| @@ -54,4 +54,7 @@ process { | |||
| errorStrategy = 'retry' | |||
| maxRetries = 2 | |||
| } | |||
| withName:CUSTOM_DUMPSOFTWAREVERSIONS { | |||
| cache = false | |||
There was a problem hiding this comment.
Why is this necessary? (I know it was like that before, but i never understood why)
There was a problem hiding this comment.
So MultiQC is always re-run regardless of whether the pipeline is cached or not.
There was a problem hiding this comment.
I think there were issues around it not being re-run properly when it had to be but not 💯
nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/main.nf
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #1278 +/- ##
==========================================
- Coverage 67.55% 67.50% -0.06%
==========================================
Files 50 50
Lines 5607 5607
==========================================
- Hits 3788 3785 -3
- Misses 1819 1822 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get tests passing again after changing the way we report software versions from each module.