-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing modules lint test #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1243 +/- ##
==========================================
- Coverage 67.54% 67.53% -0.02%
==========================================
Files 50 50
Lines 5611 5615 +4
==========================================
+ Hits 3790 3792 +2
- Misses 1821 1823 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found the issue #1235 and the solution is already implemented on this PR 😍
I tested locally and it worked. Thanks!
Was going to approve but pytest is failing...
I think that the CI failure was a temporary random thing. Merged in upstream changes so tests now rerunning. I'm assuming that they'll pass now, and this already has a ✅ review so will set to auto-merge when the finish (if passing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have automatically been merged a while ago
The
main_nf
modules lint tests was failing with errors when the process section of a module was missing, as reported in #1235. I added checks for that process definition exist before proceeding the rest of the lint tests. In addition, the failing tests for local modules were not reported at all. They are now reported as warnings.PR checklist
CHANGELOG.md
is updateddocs
is updated