Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing modules lint test #1243

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Conversation

ErikDanielsson
Copy link
Contributor

The main_nf modules lint tests was failing with errors when the process section of a module was missing, as reported in #1235. I added checks for that process definition exist before proceeding the rest of the lint tests. In addition, the failing tests for local modules were not reported at all. They are now reported as warnings.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1243 (1acbca3) into dev (bc8e01c) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1243      +/-   ##
==========================================
- Coverage   67.54%   67.53%   -0.02%     
==========================================
  Files          50       50              
  Lines        5611     5615       +4     
==========================================
+ Hits         3790     3792       +2     
- Misses       1821     1823       +2     
Impacted Files Coverage Δ
nf_core/modules/lint/main_nf.py 81.87% <50.00%> (-0.88%) ⬇️
nf_core/modules/lint/__init__.py 84.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8e01c...1acbca3. Read the comment docs.

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found the issue #1235 and the solution is already implemented on this PR 😍
I tested locally and it worked. Thanks!
Was going to approve but pytest is failing...

JoseEspinosa added a commit to JoseEspinosa/nf-core-chipseq that referenced this pull request Sep 15, 2021
@ewels
Copy link
Member

ewels commented Nov 16, 2021

I think that the CI failure was a temporary random thing.

Merged in upstream changes so tests now rerunning. I'm assuming that they'll pass now, and this already has a ✅ review so will set to auto-merge when the finish (if passing).

@ewels ewels enabled auto-merge November 16, 2021 23:57
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have automatically been merged a while ago

@ewels ewels merged commit e00e4c0 into nf-core:dev Nov 26, 2021
@ErikDanielsson ErikDanielsson deleted the fix-failing-lint branch July 25, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cryptic error by lint when file in modules/local has no process definition
4 participants