Lint the modules.json
for uninstalled modules
#1149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new pipeline lint check (
nf-core lint
) which looks for module entries in themodules.json
of modules that are not actually installed in the pipeline.I thought it makes sense to package that into the
nf-core lint
command as it looks at a general pipeline file (modules.json
) and compares that against all installed modules. Thenf-core modules lint
command is more module-centric, meaning that it runs specific lint tests for every module separately. Therefore I think it is more logical to add this check here.PR checklist
CHANGELOG.md
is updateddocs
is updated