Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in parameter validation #1088

Merged
merged 2 commits into from
May 19, 2021

Conversation

KevinMenden
Copy link
Contributor

@KevinMenden KevinMenden commented May 18, 2021

Fixes the bug described in #1087

Now typos like --clip_R1 instead of --clip_r1 are properly recognized again.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1088 (2602843) into dev (7ba366d) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1088      +/-   ##
==========================================
+ Coverage   72.20%   72.24%   +0.04%     
==========================================
  Files          36       36              
  Lines        4547     4547              
==========================================
+ Hits         3283     3285       +2     
+ Misses       1264     1262       -2     
Impacted Files Coverage Δ
nf_core/modules/lint.py 75.47% <0.00%> (+0.21%) ⬆️
nf_core/bump_version.py 89.70% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49bf61...2602843. Read the comment docs.

@KevinMenden
Copy link
Contributor Author

I have also relaxed the module tests, such that they are currently only requiring that there are no failed tests and that there are at least some passed tests. Because it can happen that we have some warnings every now and then.
This is clearly not ideal and we still need to improve those module lint tests, but it won't bug us as much anymore and should still capture anything that's breaking something.

assert len(module_lint.passed) == 20
assert len(module_lint.warned) == 0
assert len(module_lint.passed) > 0
assert len(module_lint.warned) >= 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line could also be removed of course, as it's always true

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really need to do some lint test refactoring.. We should think about prioritising this as a project soon.

@KevinMenden
Copy link
Contributor Author

Definitely .... I thought about it twice now but never came up with really satisfying solution yet 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants