Don't clear entire requests_cache cache when polling the website #1060
+27
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better as we don't lose the cache from other calls, but we do still get fresh data from the website poll. As a side-effect, we lose the INFO log messages which closes nf-core#1029
This comment has been minimized.
This comment has been minimized.
|
I recommend viewing the diff with whitespace turned off.. |
KevinMenden
approved these changes
May 10, 2021
There was a problem hiding this comment.
This looks pretty solid to me 👍
However I'm also not very familiar with that part of the code, so an additional review by @mashehu might be a good idea 👍
mashehu
approved these changes
May 10, 2021
|
Thanks both! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better as we don't lose the cache from other calls, but we do still get fresh data from the website poll.
As a side-effect, we lose the
INFOlog messages which closes #1029PR checklist
CHANGELOG.mdis updateddocsis updated