Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL2 update, mostly schema and config, a few linting items #111

Merged
merged 16 commits into from Oct 7, 2021
Merged

DSL2 update, mostly schema and config, a few linting items #111

merged 16 commits into from Oct 7, 2021

Conversation

klkeys
Copy link
Contributor

@klkeys klkeys commented Oct 7, 2021

PR checklist

  • This comment contains a description of changes (with reason).
  • CHANGELOG.md is updated.

updated nextflow_schema.json should now work with Nextflow Tower

see before/after screenshots

Screen Shot 2021-10-06 at 14 33 43
Screen Shot 2021-10-07 at 14 22 06

klkeys added 16 commits October 7, 2021 10:27
@klkeys
fix to schema, added missing refs, added some descriptions, pipeline …
3287bf5 
…skipping now defaults to false for all steps
@klkeys
don't think that trimming options should have blank default, also enf…
13e126e 
…orced directory path type for some parameters cited as paths
@klkeys
pipeline step skipping shouldn't have blank default either
e3cccbd
@klkeys
test: remove trimming options, pipeline skipping options, see if that…
eb1edab 
… bisects JSON display problem
@klkeys
test: remove reference genome options, see if that bisects JSON displ…
7a75f96 
…ay problem
@klkeys
test: remove entire JSON object descriptions, see if that bisects JSO…
fa28e54 
…N display problem
@klkeys
test: remove reference genome JSON object description, see if that bi…
0d08924 
…sects JSON display problem
@klkeys
test: add back JSON object description, see if that bisects JSON disp…
6daabc3 
…lay problem
@klkeys
bisected problem to reference genome section, pinning some changes he…
e1201c9 
…re before further debugging
@klkeys
bt_indeces --> bt_indices everywhere, minor schema JSON fixes
8294746
@klkeys
test: add back some of reference_genome_options, see if schema breaks
f2ba996
@klkeys
test: see if updated schema works. Pruned a few unused options along …
436d09a 
…the way, particularly .
@klkeys
.nf-core-lint.yml --> .nf-core.yml to appease linter
5c9ae1f
@klkeys
schema/config modification to appease the linter
dd8f3b6
@klkeys
updating modules to appease the linter
e325bf6
@klkeys
noted updated schema in CHANGELOG
15e91a9
@lpantano lpantano merged commit 42894f2 into nf-core:dsl2 Oct 7, 2021
@klkeys klkeys deleted the dsl2 branch October 7, 2021 23:10
nschcolnicov pushed a commit that referenced this pull request Oct 10, 2024
@edmundmiller
Merge pull request #111 from maxulysse/dev
4868b84 
prepare release: 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkeys @lpantano