Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates: Fix #17, disables umi-tools qc in MultiQC, adds missing versions and updates outputs #18

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Various updates: Fix #17, disables umi-tools qc in MultiQC, adds missing versions and updates outputs #18

merged 3 commits into from
Apr 30, 2024

Conversation

lianov
Copy link
Member

@lianov lianov commented Apr 30, 2024

Main changes here include the following:

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5866bb8

+| ✅ 168 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-30 18:45:45

@lianov
Copy link
Member Author

lianov commented Apr 30, 2024

@atrull314 : as discussed here is the PR. Should be a quick review.

I noted that the test here (through GitHub Actions) now has a different issue than before since #17 is solved. But for this purpose, I think we can troubleshoot this at a later time (works fine when git cloned).

@lianov lianov requested a review from atrull314 April 30, 2024 19:15
@atrull314 atrull314 merged commit ad3b092 into nf-core:dev Apr 30, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrull314 atrull314 Awaiting requested review from atrull314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find alternative optimization solution to nf-core modules to avoid linting issues
2 participants
@lianov @atrull314