-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace featureCounts with Salmon quant #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe the checking that NXF 20.10 is used but otherwise good
Not an issue, just a doubt Hi, is there any reason for removing quantification from HiSAT2 alignments? |
Hi @harish0201 . I wrote a brief description for this in the CHANGELOG (see links to papers there too) and a footnote in the main README at the end of this section. But to summarise, |
Replace
--aligner star
with--aligner star_salmon
Remove HISAT2 quantification
Add Groovy functions to check for
--genome
existence and to get reference filesMoved all genome related file processing and indices creation to
prepare_genome
sub-workflowFixed Add decoy-aware indexing for salmon #515 - Add decoy-aware indexing for salmon
Fixed Significantly different versions of STAR in star_rsem (2.7.6a) and star (2.6.1d) #498 - Significantly different versions of STAR in star_rsem (2.7.6a) and star (2.6.1d)
Partially fixed Use of salmon counts for DESeq2 #499 - Use of salmon counts for DESeq2
Parameter changes:
--fc_extra_attributes
--gtf_extra_attributes
--fc_group_features
--gtf_group_features
--fc_count_type
--gtf_count_type
--fc_group_features_type
--gtf_group_features_type
--skip_featurecounts
-