Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to unused "skip_sample_count" value in email templates #1459

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

robsyme
Copy link
Contributor

@robsyme robsyme commented Nov 29, 2024

The email templates attempt to resolve a variable skip_sample_count but this variable is never created or referenced anywhere else in the workflow.

Verified

This commit was signed with the committer’s verified signature.
mloubout Mathias Louboutin
Copy link

github-actions bot commented Nov 29, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c4fb145

+| ✅ 185 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: 3.17.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-29 20:17:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant