Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for local module HGNC_DOWNLOAD #540

Closed
wants to merge 3 commits into from
Closed

Add test for local module HGNC_DOWNLOAD #540

wants to merge 3 commits into from
+88 −1

Conversation

atrigila
Copy link

@atrigila atrigila commented Nov 26, 2024 •
edited
Loading

Closes #524

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila self-assigned this Nov 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b7f52c6

+| ✅ 219 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-26 17:50:18

@atrigila
Copy link
Author

For some reason I am unable to merge this PR:
image

@grst grst closed this Nov 27, 2024
@grst
Copy link
Member

grst commented Nov 27, 2024 •
edited
Loading

image

Wanted to close + reopen and it now tells me this... so maybe there's just nothing to do

@atrigila atrigila mentioned this pull request Nov 27, 2024
Closed
atrigila added a commit to atrigila/rnafusion that referenced this pull request Nov 27, 2024
@atrigila
Merge pull request nf-core#540 from atrigila/hgnc
4d84f3c 
Add test for local module `HGNC_DOWNLOAD`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@grst grst Awaiting requested review from grst

@nschcolnicov nschcolnicov Awaiting requested review from nschcolnicov

Assignees

@atrigila atrigila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atrigila @grst @apeltzer